Page 1 of 1

There are some weird quirks with the forum...

Posted: Sun May 07, 2017 11:58 pm
by Pryde
Seems like all the drop down menus keep popping up and when you close one and then close another the first one pops back open again. At first I thought it was just something janky with the mobile site but it's doing it on my desktop, also. ><

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 4:50 am
by Nichalus
I noticed that myself last night.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 6:20 am
by Jagtai
I'll notify goober. This is above my paygrade.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 6:30 am
by Jagtai
So, it seems that it is a style issue, since goober has just updated the software last night.

I've contacted him and told him of the issue.

Unless he can fix said issue, I'll deactivate the style until we have something usable to replace it with.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 11:23 am
by Archangel
After a quick search, it looks like the DIV class "dropdown" in phpBB used to include "display: none;" by default, but now does not, so everything displays by default. Further, since the JS code in the theme assumed display: none was the default behavior, clicking the controls fires a "toggle" function that just switches it between "display: block" and "display: none". Since, without any explicit setting, a DIV is set to "display: block," and the toggle switches it to "display: none" when you click what should control the menu.

Worse, since there's JS code looking for a click away from a drop-down menu (so that it hides when you want to stop using it), clicking away makes it reappear (because it uses the same toggle, which sees that it's set to display: none and switches it back to display: block).

From what I can tell, editing the "dropdown" class in a central CSS file should fix it. Based on my fiddling with my browser console, it looks like that's in common.css under the theme folder of our primary theme (/forum/styles/proDVGFX/theme/common.css) and that adding "display: none;" to the .dropdown class fixes it.

Code: Select all

.dropdown {
	display: none; /* <-- this fixes it */
	position: absolute;
	left: 0;
	top: 1.2em;
	z-index: 2;
	border: 1px solid transparent;
	border-radius: 5px;
	padding: 9px 0 0;
	margin-right: -500px;
}

There are also other things that have been broken. The format buttons, for example.

I also think, based on what I'm seeing posting this, that under .codebox code, white-space should be set to pre, not normal. But maybe I'm crazy.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 12:20 pm
by Pryde
I actually understood all that. I guess some of the stuff I learned in class did stick after all.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 1:34 pm
by Jagtai
You're probably right, Arch.

For now, we'll set prosilver as default. I'll do it tomorrow, if goober doesn't beat me to it ;-)

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 1:43 pm
by Nichalus
Archangel wrote: Mon May 08, 2017 11:23 am

Code: Select all

.dropdown {
	display: none; /* <-- this fixes it */
	position: absolute;
	left: 0;
	top: 1.2em;
	z-index: 2;
	border: 1px solid transparent;
	border-radius: 5px;
	padding: 9px 0 0;
	margin-right: -500px;
}

You just unlocked my Sleeper Code to activate my programming to kill all Confederate Soldiers and assassinate General Robert E Lee.....wait....what?

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 5:16 pm
by Cadden
I'm doing training this week, but if I have time I'll look into it and see if I can find a fix, or figure out how to fix as suggested. I was thinking there must have been some kind of update that was applied, as well, but fixing from a cell phone isn't exactly ideal.

Re: There are some weird quirks with the forum...

Posted: Mon May 08, 2017 8:06 pm
by Jagtai
I apologize for the eye-watering colours, but at least the drop down menus are working.

Someone more knowledgeable in CSS than I can try to fix it (Cadden). Otherwise, the author of proDVGFX (our custom style) is working on a fix, but has no ETA.

Re: There are some weird quirks with the forum...

Posted: Fri May 12, 2017 4:56 am
by Cadden
I will try to get a fix worked out this weekend. I've been training this week with limited Internetz access. Hopefully it's as simple as Arch's theory. If not, we'll just have to wait for the author to update it. I'm not well versed in CSS to dig that deep into this. I'd probably break the forums, knowing my luck. :?

Re: There are some weird quirks with the forum...

Posted: Fri May 12, 2017 6:12 am
by Mir
Mir wants to keep this skin. Mir likes this skin. Can Mir keep this skin?

Seriously though.

Re: There are some weird quirks with the forum...

Posted: Fri May 12, 2017 1:46 pm
by Cadden

Re: There are some weird quirks with the forum...

Posted: Fri May 12, 2017 6:11 pm
by Mir
Mir wants choice!

Re: There are some weird quirks with the forum...

Posted: Fri May 12, 2017 10:44 pm
by Jagtai
Choice is for the weak!

Re: There are some weird quirks with the forum...

Posted: Sat May 13, 2017 4:20 am
by Cadden

Re: There are some weird quirks with the forum...

Posted: Sat May 13, 2017 6:08 am
by Mir
Mir doesn't know what the cause is, but the effect is that you smell like poop.

Re: There are some weird quirks with the forum...

Posted: Sat May 13, 2017 7:27 am
by Cadden
The "display: none;" code fixed the drop-down issue, but, of course, there's still nuances that need to be addressed before we can re-activate the old style. Might just be easier, at this point, to wait for an official release, I'd think.

I browsed their current demo database, there really isn't anything that particularly strikes me as a good alternative theme to implement now.